net: Fix a memmove bug in dev_gro_receive()
authorJarek Poplawski <jarkao2@gmail.com>
Wed, 11 Aug 2010 02:02:10 +0000 (02:02 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 7 Nov 2011 21:47:33 +0000 (13:47 -0800)
commitf84fa42e6d292e06e7462e286aacc92511201ddf
tree238ac5e0e1e6f6aa6ce1dce19a179e43c1c9386d
parent860652a77bfa9b221c9086f67f365b9947175a54
net: Fix a memmove bug in dev_gro_receive()

commit e5093aec2e6b60c3df2420057ffab9ed4a6d2792 upstream.

>Xin Xiaohui wrote:
> I looked into the code dev_gro_receive(), found the code here:
> if the frags[0] is pulled to 0, then the page will be released,
> and memmove() frags left.
> Is that right? I'm not sure if memmove do right or not, but
> frags[0].size is never set after memove at least. what I think
> a simple way is not to do anything if we found frags[0].size == 0.
> The patch is as followed.
...

This version of the patch fixes the bug directly in memmove.

Reported-by: "Xin, Xiaohui" <xiaohui.xin@intel.com>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/core/dev.c