blkcg: Unlock blkcg_pol_mutex only once when cpd == NULL
authorBart Van Assche <bart.vanassche@sandisk.com>
Thu, 29 Sep 2016 15:33:30 +0000 (08:33 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Oct 2016 07:45:27 +0000 (03:45 -0400)
commitf974fb2623b409f59eda7abbebb6c4626e7614ab
treeee83aa3bdbbe2cf5facfa89b2c6abfa774fc310a
parent38c7c171b160f84113c10e9428e03ed4dc33cfe6
blkcg: Unlock blkcg_pol_mutex only once when cpd == NULL

commit bbb427e342495df1cda10051d0566388697499c0 upstream.

Unlocking a mutex twice is wrong. Hence modify blkcg_policy_register()
such that blkcg_pol_mutex is unlocked once if cpd == NULL. This patch
avoids that smatch reports the following error:

block/blk-cgroup.c:1378: blkcg_policy_register() error: double unlock 'mutex:&blkcg_pol_mutex'

Fixes: 06b285bd1125 ("blkcg: fix blkcg_policy_data allocation bug")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/blk-cgroup.c