jbd2: avoid infinite loop when destroying aborted journal
authorJan Kara <jack@suse.com>
Tue, 28 Jul 2015 18:57:14 +0000 (14:57 -0400)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 13 Nov 2015 18:14:15 +0000 (13:14 -0500)
commitffb04e43c08ae23a4b3995ee77cc7fcc17a7afba
tree9774e48ce6ccf6cd7e5278658c2c4220b858ce1a
parentb12403044336e7d567f309eb443aa9acf76380af
jbd2: avoid infinite loop when destroying aborted journal

[ Upstream commit 841df7df196237ea63233f0f9eaa41db53afd70f ]

Commit 6f6a6fda2945 "jbd2: fix ocfs2 corrupt when updating journal
superblock fails" changed jbd2_cleanup_journal_tail() to return EIO
when the journal is aborted. That makes logic in
jbd2_log_do_checkpoint() bail out which is fine, except that
jbd2_journal_destroy() expects jbd2_log_do_checkpoint() to always make
a progress in cleaning the journal. Without it jbd2_journal_destroy()
just loops in an infinite loop.

Fix jbd2_journal_destroy() to cleanup journal checkpoint lists of
jbd2_log_do_checkpoint() fails with error.

Reported-by: Eryu Guan <guaneryu@gmail.com>
Tested-by: Eryu Guan <guaneryu@gmail.com>
Fixes: 6f6a6fda294506dfe0e3e0a253bb2d2923f28f0a
Signed-off-by: Jan Kara <jack@suse.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
fs/jbd2/checkpoint.c
fs/jbd2/commit.c
fs/jbd2/journal.c
include/linux/jbd2.h