USB: cdc-acm: fix potential null-pointer dereference
authorJohan Hovold <jhovold@gmail.com>
Tue, 22 Mar 2011 10:12:10 +0000 (11:12 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 28 Mar 2011 14:31:22 +0000 (07:31 -0700)
commit 15e5bee33ffc11d0e5c6f819a65e7881c5c407be upstream.

Must check return value of tty_port_tty_get.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/class/cdc-acm.c

index 2b26ff81b59d65d043914cedf2132d56bdf6c9b4..9872610de261669ad041b67050ba4ffa07bcbd50 100644 (file)
@@ -534,6 +534,8 @@ static void acm_softint(struct work_struct *work)
        if (!ACM_READY(acm))
                return;
        tty = tty_port_tty_get(&acm->port);
+       if (!tty)
+               return;
        tty_wakeup(tty);
        tty_kref_put(tty);
 }