Unionfs: remove unnecessary lower atime updates

No need for this because our readpage calls vfs_read on the lower objects,
which would update the atime as/if needed.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>

diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c
index 75e7fff09754c6ed199acfdecaea72ececf09e21..251ffdc618532910ccb7b583dc7a191ff675df5f 100644 (file)
--- a/fs/unionfs/file.c
+++ b/fs/unionfs/file.c
@@ -31,10 +31,6 @@ static ssize_t unionfs_read(struct file *file, char __user *buf,
 
        err = do_sync_read(file, buf, count, ppos);
 
-       if (err >= 0)
-               touch_atime(unionfs_lower_mnt(file->f_path.dentry),
-                           unionfs_lower_dentry(file->f_path.dentry));
-
 out:
        unionfs_read_unlock(file->f_path.dentry->d_sb);
        unionfs_check_file(file);
@@ -58,10 +54,6 @@ static ssize_t unionfs_aio_read(struct kiocb *iocb, const struct iovec *iov,
        if (err == -EIOCBQUEUED)
                err = wait_on_sync_kiocb(iocb);
 
-       if (err >= 0)
-               touch_atime(unionfs_lower_mnt(file->f_path.dentry),
-                           unionfs_lower_dentry(file->f_path.dentry));
-
 out:
        unionfs_read_unlock(file->f_path.dentry->d_sb);
        unionfs_check_file(file);

diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c
index e5d7e996638f8895f06fa850df67f307bdf93a90..f615d02a73064f2193a1d40fd65d8edcb3aadca0 100644 (file)
--- a/fs/unionfs/mmap.c
+++ b/fs/unionfs/mmap.c
@@ -245,12 +245,6 @@ static int unionfs_readpage(struct file *file, struct page *page)
 
        err = unionfs_do_readpage(file, page);
 
-       if (!err) {
-               touch_atime(unionfs_lower_mnt(file->f_path.dentry),
-                           unionfs_lower_dentry(file->f_path.dentry));
-               unionfs_copy_attr_times(file->f_path.dentry->d_inode);
-       }
-
        /*
         * we have to unlock our page, b/c we _might_ have gotten a locked
         * page.  but we no longer have to wakeup on our page here, b/c