net: macb: add missed tasklet_kill
authorChuhong Yuan <hslester96@gmail.com>
Thu, 28 Nov 2019 02:00:21 +0000 (10:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2019 08:21:32 +0000 (09:21 +0100)
[ Upstream commit 61183b056b49e2937ff92a1424291ba36a6f6d05 ]

This driver forgets to kill tasklet in remove.
Add the call to fix it.

Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/cadence/macb_main.c

index d98077ab306bd9e0ee5642c06c348c90f439ef03..98f769393250e1359c33b44f8d4f7bd0ac31ecb9 100644 (file)
@@ -4192,6 +4192,7 @@ static int macb_remove(struct platform_device *pdev)
                mdiobus_free(bp->mii_bus);
 
                unregister_netdev(dev);
+               tasklet_kill(&bp->hresp_err_tasklet);
                clk_disable_unprepare(bp->tx_clk);
                clk_disable_unprepare(bp->hclk);
                clk_disable_unprepare(bp->pclk);