net: sched: fix warning in tcindex_alloc_perfect_hash
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 25 Jun 2021 20:23:48 +0000 (23:23 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:21:03 +0000 (16:21 +0200)
[ Upstream commit 3f2db250099f46988088800052cdf2332c7aba61 ]

Syzbot reported warning in tcindex_alloc_perfect_hash. The problem
was in too big cp->hash, which triggers warning in kmalloc. Since
cp->hash comes from userspace, there is no need to warn if value
is not correct

Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()")
Reported-and-tested-by: syzbot+1071ad60cd7df39fdadb@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Acked-by: Cong Wang <cong.wang@bytedance.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/cls_tcindex.c

index 70ee78d8f8fb837022d177ae70c91ff35f1eccbd..7aafb402e5c779af27e2d211b6a9da8a13403259 100644 (file)
@@ -247,7 +247,7 @@ static int tcindex_alloc_perfect_hash(struct tcindex_data *cp)
        int i, err = 0;
 
        cp->perfect = kcalloc(cp->hash, sizeof(struct tcindex_filter_result),
-                             GFP_KERNEL);
+                             GFP_KERNEL | __GFP_NOWARN);
        if (!cp->perfect)
                return -ENOMEM;