usb: misc: legousbtower: Fix memory leak
authorMaksim Salau <maksim.salau@gmail.com>
Sat, 13 May 2017 20:49:26 +0000 (23:49 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Aug 2017 01:14:50 +0000 (02:14 +0100)
commit 0bd193d62b4270a2a7a09da43ad1034c7ca5b3d3 upstream.

get_version_reply is not freed if function returns with success.

Fixes: 942a48730faf ("usb: misc: legousbtower: Fix buffers on stack")
Reported-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Maksim Salau <maksim.salau@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/misc/legousbtower.c

index 5f5b626c2dd718edf6c95239a57553aaa5e291bf..0f9b094343f5bda768e06eec5d9d77eee7bd96af 100644 (file)
@@ -953,6 +953,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device
                 USB_MAJOR, dev->minor);
 
 exit:
+       kfree(get_version_reply);
        return retval;
 
 error: