ASoC: Intel: mrfld: fix incorrect check on p->sink
authorColin Ian King <colin.king@canonical.com>
Tue, 19 Nov 2019 11:36:40 +0000 (11:36 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Apr 2020 05:57:19 +0000 (07:57 +0200)
commit f5e056e1e46fcbb5f74ce560792aeb7d57ce79e6 upstream.

The check on p->sink looks bogus, I believe it should be p->source
since the following code blocks are related to p->source. Fix
this by replacing p->sink with p->source.

Fixes: 24c8d14192cc ("ASoC: Intel: mrfld: add DSP core controls")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Copy-paste error")
Link: https://lore.kernel.org/r/20191119113640.166940-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/intel/atom/sst-atom-controls.c

index d55388e082e18189b71693bacf3994fdc6372a7c..b070d47547450ffa67ff4d423d173a2e248c65e8 100644 (file)
@@ -1318,7 +1318,7 @@ int sst_send_pipe_gains(struct snd_soc_dai *dai, int stream, int mute)
                                dai->capture_widget->name);
                w = dai->capture_widget;
                snd_soc_dapm_widget_for_each_source_path(w, p) {
-                       if (p->connected && !p->connected(w, p->sink))
+                       if (p->connected && !p->connected(w, p->source))
                                continue;
 
                        if (p->connect &&  p->source->power &&