fs/unionfs/: Remove alloc_filldir_node
authorJosef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
Sun, 25 Feb 2007 22:30:34 +0000 (17:30 -0500)
committerErez Zadok <ezk@cs.sunysb.edu>
Tue, 11 Nov 2014 02:29:42 +0000 (21:29 -0500)
alloc_filldir_node was used only once. Additionally, all the arguments
passed to it were ignored wasting stack space for no reason whatsoever.

Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
fs/unionfs/rdstate.c

index e2402852996273ddf7ff72b05370a4227eefa1c4..b67a86a99a06437b7f68cda8c3566e2db569d63a 100644 (file)
@@ -225,12 +225,6 @@ struct filldir_node *find_filldir_node(struct unionfs_dir_state *rdstate,
        return cursor;
 }
 
-static struct filldir_node *alloc_filldir_node(const char *name, int namelen,
-                                              unsigned int hash, int bindex)
-{
-       return kmem_cache_alloc(unionfs_filldir_cachep, GFP_KERNEL);
-}
-
 int add_filldir_node(struct unionfs_dir_state *rdstate, const char *name,
                     int namelen, int bindex, int whiteout)
 {
@@ -246,7 +240,7 @@ int add_filldir_node(struct unionfs_dir_state *rdstate, const char *name,
        index = hash % rdstate->size;
        head = &(rdstate->list[index]);
 
-       new = alloc_filldir_node(name, namelen, hash, bindex);
+       new = kmem_cache_alloc(unionfs_filldir_cachep, GFP_KERNEL);
        if (!new) {
                err = -ENOMEM;
                goto out;