ath9k: fix storage endpoint lookup
authorJohan Hovold <johan@kernel.org>
Tue, 10 Dec 2019 11:44:20 +0000 (12:44 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 22 May 2020 20:19:17 +0000 (21:19 +0100)
commit 0ef332951e856efa89507cdd13ba8f4fb8d4db12 upstream.

Make sure to use the current alternate setting when verifying the
storage interface descriptors to avoid submitting an URB to an invalid
endpoint.

Failing to do so could cause the driver to misbehave or trigger a WARN()
in usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/ath/ath9k/hif_usb.c

index 2bb8dd09fec275294fd496ec84770b792f6434a9..abe99aa6b00208110b8ae0b5fcfa5ced94b4dd21 100644 (file)
@@ -1141,7 +1141,7 @@ err_fw:
 static int send_eject_command(struct usb_interface *interface)
 {
        struct usb_device *udev = interface_to_usbdev(interface);
-       struct usb_host_interface *iface_desc = &interface->altsetting[0];
+       struct usb_host_interface *iface_desc = interface->cur_altsetting;
        struct usb_endpoint_descriptor *endpoint;
        unsigned char *cmd;
        u8 bulk_out_ep;