gpio: max77620: Fix missing release of interrupt
authorDmitry Osipenko <digetx@gmail.com>
Thu, 9 Jul 2020 17:11:59 +0000 (20:11 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Aug 2020 13:48:10 +0000 (15:48 +0200)
commit 2a5e6f7eede8cd1c4bac0b8ec6491cec4e75c99a upstream.

The requested interrupt is never released by the driver. Fix this by
using the resource-managed variant of request_threaded_irq().

Fixes: ab3dd9cc24d4 ("gpio: max77620: Fix interrupt handling")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: <stable@vger.kernel.org> # 5.5+
Link: https://lore.kernel.org/r/20200709171203.12950-3-digetx@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpio-max77620.c

index 313bd02dd89310940cbb1e424bbc6201f14a5e74..bd6c4faea639c081f7c7828bbded2537582384d0 100644 (file)
@@ -305,8 +305,9 @@ static int max77620_gpio_probe(struct platform_device *pdev)
        gpiochip_irqchip_add_nested(&mgpio->gpio_chip, &max77620_gpio_irqchip,
                                    0, handle_edge_irq, IRQ_TYPE_NONE);
 
-       ret = request_threaded_irq(gpio_irq, NULL, max77620_gpio_irqhandler,
-                                  IRQF_ONESHOT, "max77620-gpio", mgpio);
+       ret = devm_request_threaded_irq(&pdev->dev, gpio_irq, NULL,
+                                       max77620_gpio_irqhandler, IRQF_ONESHOT,
+                                       "max77620-gpio", mgpio);
        if (ret < 0) {
                dev_err(&pdev->dev, "failed to request IRQ: %d\n", ret);
                return ret;