Unionfs: remove unnecessary lower atime updates
authorErez Zadok <ezk@cs.sunysb.edu>
Sun, 11 Nov 2007 23:34:34 +0000 (18:34 -0500)
committerErez Zadok <ezk@cs.sunysb.edu>
Sun, 1 Dec 2013 00:52:18 +0000 (19:52 -0500)
No need for this because our readpage calls vfs_read on the lower objects,
which would update the atime as/if needed.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
fs/unionfs/file.c
fs/unionfs/mmap.c

index 126df5ef778753de3ae416bbde71f005190b4562..809e0f14adbc19cc5bca25492e4ff7056ea44801 100644 (file)
@@ -31,10 +31,6 @@ static ssize_t unionfs_read(struct file *file, char __user *buf,
 
        err = do_sync_read(file, buf, count, ppos);
 
-       if (err >= 0)
-               touch_atime(unionfs_lower_mnt(file->f_path.dentry),
-                           unionfs_lower_dentry(file->f_path.dentry));
-
 out:
        unionfs_read_unlock(file->f_path.dentry->d_sb);
        unionfs_check_file(file);
@@ -58,10 +54,6 @@ static ssize_t unionfs_aio_read(struct kiocb *iocb, const struct iovec *iov,
        if (err == -EIOCBQUEUED)
                err = wait_on_sync_kiocb(iocb);
 
-       if (err >= 0)
-               touch_atime(unionfs_lower_mnt(file->f_path.dentry),
-                           unionfs_lower_dentry(file->f_path.dentry));
-
 out:
        unionfs_read_unlock(file->f_path.dentry->d_sb);
        unionfs_check_file(file);
index bb00fd501976fac4e141835d194a972767c02248..34fd8aa0f925be0ff13be6be02e2e59f700ce3b5 100644 (file)
@@ -212,12 +212,6 @@ static int unionfs_readpage(struct file *file, struct page *page)
 
        err = unionfs_do_readpage(file, page);
 
-       if (!err) {
-               touch_atime(unionfs_lower_mnt(file->f_path.dentry),
-                           unionfs_lower_dentry(file->f_path.dentry));
-               unionfs_copy_attr_times(file->f_path.dentry->d_inode);
-       }
-
        /*
         * we have to unlock our page, b/c we _might_ have gotten a locked
         * page.  but we no longer have to wakeup on our page here, b/c