i40e: add num_vectors checker in iwarp handler
authorSergey Nemov <sergey.nemov@intel.com>
Fri, 7 Aug 2020 20:55:14 +0000 (13:55 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Aug 2020 13:32:35 +0000 (15:32 +0200)
[ Upstream commit 7015ca3df965378bcef072cca9cd63ed098665b5 ]

Field num_vectors from struct virtchnl_iwarp_qvlist_info should not be
larger than num_msix_vectors_vf in the hw struct.  The iwarp uses the
same set of vectors as the LAN VF driver.

Fixes: e3219ce6a7754 ("i40e: Add support for client interface for IWARP driver")
Signed-off-by: Sergey Nemov <sergey.nemov@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

index 6a677fd540d649cc8d0f950224a37fe5696d5b64..a1b464a91d937d67bc914df9ae226b563276b0a8 100644 (file)
@@ -442,6 +442,16 @@ static int i40e_config_iwarp_qvlist(struct i40e_vf *vf,
        u32 next_q_idx, next_q_type;
        u32 msix_vf, size;
 
+       msix_vf = pf->hw.func_caps.num_msix_vectors_vf;
+
+       if (qvlist_info->num_vectors > msix_vf) {
+               dev_warn(&pf->pdev->dev,
+                        "Incorrect number of iwarp vectors %u. Maximum %u allowed.\n",
+                        qvlist_info->num_vectors,
+                        msix_vf);
+               goto err;
+       }
+
        size = sizeof(struct virtchnl_iwarp_qvlist_info) +
               (sizeof(struct virtchnl_iwarp_qv_info) *
                                                (qvlist_info->num_vectors - 1));