b43legacy: Fix error due to MMIO access with SSB unpowered
authorLarry Finger <Larry.Finger@lwfinger.net>
Sun, 6 May 2012 21:01:05 +0000 (16:01 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Jun 2012 07:18:24 +0000 (15:18 +0800)
commit 8f4b20388fa77226a3605627a33a23f90d559e50 upstream.

There is a dummy read of a PCI MMIO register that occurs before the SSB bus
has been powered, which is an error. This bug has not been seen earlier,
but was apparently exposed when udev was updated to version 182.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/b43legacy/main.c

index df7e16dfb36c56ca426274fd9d9e7270f1dd1932..a98db30b7acbe13b885885e270ac15123e3a4a5c 100644 (file)
@@ -1571,8 +1571,6 @@ static void b43legacy_request_firmware(struct work_struct *work)
        const char *filename;
        int err;
 
-       /* do dummy read */
-       ssb_read32(dev->dev, SSB_TMSHIGH);
        if (!fw->ucode) {
                if (rev == 2)
                        filename = "ucode2";