wil6210: remove reset file from debugfs
authorKarthick Gopalasubramanian <kargop@codeaurora.org>
Thu, 23 Aug 2018 11:47:05 +0000 (14:47 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Apr 2020 07:03:13 +0000 (09:03 +0200)
commit 32dcfe8316cdbd885542967c0c85f5b9de78874b upstream.

Reset file is not used and may cause race conditions
with operational driver if used.

Signed-off-by: Karthick Gopalasubramanian <kargop@codeaurora.org>
Signed-off-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/ath/wil6210/debugfs.c

index acd95ca0430b99d7b9fe592df41739c0fa46cbee..55a809cb31054467af0cc54af1e9bc49e50e51a8 100644 (file)
@@ -730,32 +730,6 @@ struct dentry *wil_debugfs_create_ioblob(const char *name,
        return debugfs_create_file(name, mode, parent, wil_blob, &fops_ioblob);
 }
 
-/*---reset---*/
-static ssize_t wil_write_file_reset(struct file *file, const char __user *buf,
-                                   size_t len, loff_t *ppos)
-{
-       struct wil6210_priv *wil = file->private_data;
-       struct net_device *ndev = wil->main_ndev;
-
-       /**
-        * BUG:
-        * this code does NOT sync device state with the rest of system
-        * use with care, debug only!!!
-        */
-       rtnl_lock();
-       dev_close(ndev);
-       ndev->flags &= ~IFF_UP;
-       rtnl_unlock();
-       wil_reset(wil, true);
-
-       return len;
-}
-
-static const struct file_operations fops_reset = {
-       .write = wil_write_file_reset,
-       .open  = simple_open,
-};
-
 /*---write channel 1..4 to rxon for it, 0 to rxoff---*/
 static ssize_t wil_write_file_rxon(struct file *file, const char __user *buf,
                                   size_t len, loff_t *ppos)
@@ -2461,7 +2435,6 @@ static const struct {
        {"desc",        0444,           &fops_txdesc},
        {"bf",          0444,           &fops_bf},
        {"mem_val",     0644,           &fops_memread},
-       {"reset",       0244,           &fops_reset},
        {"rxon",        0244,           &fops_rxon},
        {"tx_mgmt",     0244,           &fops_txmgmt},
        {"wmi_send", 0244,              &fops_wmi},