hwmon: (pmbus) Add Vin unit off handling

[ Upstream commit a5436af598779219b375c1977555c82def1c35d0 ]

If there is an input undervoltage fault, reported in STATUS_INPUT
command response, there is quite likely a "Unit Off For Insufficient
Input Voltage" condition as well.

Add a constant for bit 3 of STATUS_INPUT. Update the Vin limit
attributes to include both bits in the mask for clearing faults.

If an input undervoltage fault occurs, causing a unit off for
insufficient input voltage, but the unit is off bit is not cleared, the
STATUS_WORD will not be updated to clear the input fault condition.
Including the unit is off bit (bit 3) allows for the input fault
condition to completely clear.

Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Link: https://lore.kernel.org/r/20220317232123.2103592-1-bjwyman@gmail.com
Fixes: b4ce237b7f7d3 ("hwmon: (pmbus) Introduce infrastructure to detect sensors and limit registers")
[groeck: Dropped unnecessary ()]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h
index bfcb13bae34bd67338e363d8b76849572d39f7d6..8b6acb7497e2efa3c15dfafc882ff26c7dea4467 100644 (file)
--- a/drivers/hwmon/pmbus/pmbus.h
+++ b/drivers/hwmon/pmbus/pmbus.h
@@ -262,6 +262,7 @@ enum pmbus_regs {
 /*
  * STATUS_VOUT, STATUS_INPUT
  */
+#define PB_VOLTAGE_VIN_OFF             BIT(3)
 #define PB_VOLTAGE_UV_FAULT            BIT(4)
 #define PB_VOLTAGE_UV_WARNING          BIT(5)
 #define PB_VOLTAGE_OV_WARNING          BIT(6)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index ed8c0d276388d05c429fae12a4a6873747221f2c..a662702632a8c586e8776fbb13b3f8261e4cf054 100644 (file)
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -1133,7 +1133,7 @@ static const struct pmbus_limit_attr vin_limit_attrs[] = {
                .reg = PMBUS_VIN_UV_FAULT_LIMIT,
                .attr = "lcrit",
                .alarm = "lcrit_alarm",
-               .sbit = PB_VOLTAGE_UV_FAULT,
+               .sbit = PB_VOLTAGE_UV_FAULT | PB_VOLTAGE_VIN_OFF,
        }, {
                .reg = PMBUS_VIN_OV_WARN_LIMIT,
                .attr = "max",