net: lpc-enet: fix error return code in lpc_mii_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 27 Apr 2020 12:15:07 +0000 (12:15 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Jun 2020 08:25:10 +0000 (10:25 +0200)
[ Upstream commit 88ec7cb22ddde725ed4ce15991f0bd9dd817fd85 ]

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: b7370112f519 ("lpc32xx: Added ethernet driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/nxp/lpc_eth.c

index 41d30f55c946be682dd6d790f5ab5ca9f6c88cea..6bd6c261f2ba9866adfd4a1efe80b9d5b7ce0c3f 100644 (file)
@@ -845,7 +845,8 @@ static int lpc_mii_init(struct netdata_local *pldat)
        if (mdiobus_register(pldat->mii_bus))
                goto err_out_unregister_bus;
 
-       if (lpc_mii_probe(pldat->ndev) != 0)
+       err = lpc_mii_probe(pldat->ndev);
+       if (err)
                goto err_out_unregister_bus;
 
        return 0;