For consistency set error msg fist then set error code
authorVasily Tarasov <tarasov@vasily.name>
Mon, 6 Apr 2015 14:38:56 +0000 (10:38 -0400)
committerVasily Tarasov <tarasov@vasily.name>
Mon, 6 Apr 2015 14:38:56 +0000 (10:38 -0400)
drivers/md/dm-dedup-target.c

index a49faadc831bcf89d6cb8247f9d2d81fd1f7e7ce..e58f6476aa5ec3978c7b567cff859f860da8e1b4 100644 (file)
@@ -634,15 +634,15 @@ static int dm_dedup_ctr(struct dm_target *ti, unsigned int argc, char **argv)
        dedup_work_pool = mempool_create_kmalloc_pool(MIN_DEDUP_WORK_IO,
                                                sizeof(struct dedup_work));
        if (!dedup_work_pool) {
-               r = -ENOMEM;
                ti->error = "failed to create mempool";
+               r = -ENOMEM;
                goto bad_mempool;
        }
 
        dc->io_client = dm_io_client_create();
        if (IS_ERR(dc->io_client)) {
-               r = PTR_ERR(dc->io_client);
                ti->error = "failed to create dm_io_client";
+               r = PTR_ERR(dc->io_client);
                goto bad_io_client;
        }
 
@@ -692,8 +692,8 @@ static int dm_dedup_ctr(struct dm_target *ti, unsigned int argc, char **argv)
                                sizeof(struct hash_pbn_value),
                                dc->pblocks, unformatted);
        if (IS_ERR(dc->kvs_hash_pbn)) {
-               r = PTR_ERR(dc->kvs_hash_pbn);
                ti->error = "failed to create sparse KVS";
+               r = PTR_ERR(dc->kvs_hash_pbn);
                goto bad_kvstore_init;
        }