sg: fix oops in the error path in sg_build_indirect()
authorMichal Schmidt <mschmidt@redhat.com>
Thu, 3 Sep 2009 12:27:08 +0000 (14:27 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 24 Sep 2009 15:43:47 +0000 (08:43 -0700)
commit e71044ee2efa4792e21d243b03d49006db66aec9 upstream.

When the allocation fails in sg_build_indirect(), an oops happens in
the error path. It's caused by an obvious typo.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Reported-by: Bob Tracy <rct@gherkin.frus.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/sg.c

index 9230402c45afcbe0c1a06188b83c99a3f39a104b..4968c4ced385f0c46a46bbd903586bef7c68dc12 100644 (file)
@@ -1811,7 +1811,7 @@ retry:
        return 0;
 out:
        for (i = 0; i < k; i++)
-               __free_pages(schp->pages[k], order);
+               __free_pages(schp->pages[i], order);
 
        if (--order >= 0)
                goto retry;