mac80211: minstrel_ht: set default tx aggregation timeout to 0
authorFelix Fietkau <nbd@openwrt.org>
Thu, 18 Feb 2016 18:49:18 +0000 (19:49 +0100)
committerJiri Slaby <jslaby@suse.cz>
Mon, 14 Mar 2016 22:10:30 +0000 (23:10 +0100)
commit 7a36b930e6ed4702c866dc74a5ad07318a57c688 upstream.

The value 5000 was put here with the addition of the timeout field to
ieee80211_start_tx_ba_session. It was originally added in mac80211 to
save resources for drivers like iwlwifi, which only supports a limited
number of concurrent aggregation sessions.

Since iwlwifi does not use minstrel_ht and other drivers don't need
this, 0 is a better default - especially since there have been
recent reports of aggregation setup related issues reproduced with
ath9k. This should improve stability without causing any adverse
effects.

Acked-by: Avery Pennarun <apenwarr@gmail.com>
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/mac80211/rc80211_minstrel_ht.c

index 7c323f27ba230a91599f34a6877caa8c17ff8605..96b6dc0155dee4bce18de71c0f06fd8c42b9a6a2 100644 (file)
@@ -454,7 +454,7 @@ minstrel_aggr_check(struct ieee80211_sta *pubsta, struct sk_buff *skb)
        if (skb_get_queue_mapping(skb) == IEEE80211_AC_VO)
                return;
 
-       ieee80211_start_tx_ba_session(pubsta, tid, 5000);
+       ieee80211_start_tx_ba_session(pubsta, tid, 0);
 }
 
 static void