usb: misc: usb3503: Update error code in print message
authorTushar Behera <tushar.b@samsung.com>
Tue, 17 Jun 2014 11:08:50 +0000 (16:38 +0530)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 20 Nov 2018 18:06:03 +0000 (18:06 +0000)
commit ec5734c41bee2ee7c938a8f34853d31cada7e67a upstream.

'err' is uninitialized, rather print the error code directly.

This also fixes following warning.
drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized
in this function [-Wmaybe-uninitialized]
    dev_err(dev, "unable to request refclk (%d)\n", err);

Signed-off-by: Tushar Behera <tushar.b@samsung.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/misc/usb3503.c

index cf562d220433679467f79cf768c24102267474c3..388137cf98867e19fd9513025d64f7fd31aa82fb 100644 (file)
@@ -192,7 +192,8 @@ static int usb3503_probe(struct usb3503 *hub)
 
                clk = devm_clk_get(dev, "refclk");
                if (IS_ERR(clk) && PTR_ERR(clk) != -ENOENT) {
-                       dev_err(dev, "unable to request refclk (%d)\n", err);
+                       dev_err(dev, "unable to request refclk (%ld)\n",
+                                       PTR_ERR(clk));
                        return PTR_ERR(clk);
                }