Unionfs: fix readonly nfs2/3 permission handling

In unionfs_permission: NFSv2/3 return EACCES on readonly-exported, locally
readonly-mounted file systems, instead of EROFS like other file systems do.
So we have no choice here but to intercept this and ignore it for NFS
branches marked readonly.  Specifically, we avoid using NFS's own "broken"
->permission method, and rely on generic_permission() to do basic checking
for us.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>

diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index 68e6985dc80f8fccf6896c373781d0a8b17db701..31391c87796bb62334eed0ac1e2578019799e350 100644 (file)
--- a/fs/unionfs/inode.c
+++ b/fs/unionfs/inode.c
@@ -845,6 +845,20 @@ static int unionfs_permission(struct inode *inode, int mask,
                                err = 0;
                }
 
+               /*
+                * NFS HACK: NFSv2/3 return EACCES on readonly-exported,
+                * locally readonly-mounted file systems, instead of EROFS
+                * like other file systems do.  So we have no choice here
+                * but to intercept this and ignore it for NFS branches
+                * marked readonly.  Specifically, we avoid using NFS's own
+                * "broken" ->permission method, and rely on
+                * generic_permission() to do basic checking for us.
+                */
+               if (err && err == -EACCES &&
+                   is_robranch_super(inode->i_sb, bindex) &&
+                   lower_inode->i_sb->s_magic == NFS_SUPER_MAGIC)
+                       err = generic_permission(lower_inode, mask, NULL);
+
                /*
                 * The permissions are an intersection of the overall directory
                 * permissions, so we fail if one fails.