gnss: sirf: fix error return code in sirf_probe()

commit 43d7ce70ae43dd8523754b17f567417e0e75dbce upstream.

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

This avoids a use-after-free in case the driver is later unbound.

Fixes: d2efbbd18b1e ("gnss: add driver for sirfstar-based receivers")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
[ johan: amend commit message; mention potential use-after-free ]
Cc: stable <stable@vger.kernel.org>	# 4.19
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c
index 4596fde16dfe622ca01324685512022b51800077..3e88e79d1053078e6286bb828f14af453048bb74 100644 (file)
--- a/drivers/gnss/sirf.c
+++ b/drivers/gnss/sirf.c
@@ -292,14 +292,18 @@ static int sirf_probe(struct serdev_device *serdev)
 
        data->on_off = devm_gpiod_get_optional(dev, "sirf,onoff",
                        GPIOD_OUT_LOW);
-       if (IS_ERR(data->on_off))
+       if (IS_ERR(data->on_off)) {
+               ret = PTR_ERR(data->on_off);
                goto err_put_device;
+       }
 
        if (data->on_off) {
                data->wakeup = devm_gpiod_get_optional(dev, "sirf,wakeup",
                                GPIOD_IN);
-               if (IS_ERR(data->wakeup))
+               if (IS_ERR(data->wakeup)) {
+                       ret = PTR_ERR(data->wakeup);
                        goto err_put_device;
+               }
 
                /*
                 * Configurations where WAKEUP has been left not connected,