drm/radeon: check buffer relocation offset
authorLeo Liu <leo.liu@amd.com>
Mon, 28 Apr 2014 13:40:22 +0000 (09:40 -0400)
committerJiri Slaby <jslaby@suse.cz>
Fri, 6 Jun 2014 10:38:17 +0000 (12:38 +0200)
commit 695daf1a8e731a4b5b89de89a61f32a4d7ad7094 upstream.

Signed-off-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/gpu/drm/radeon/radeon_uvd.c

index 83936473f8e488c44ef82e3c425ff5904714bbd3..a656b1a7e10a3b0c721998026c2a3e2b82418dfa 100644 (file)
@@ -464,6 +464,10 @@ static int radeon_uvd_cs_reloc(struct radeon_cs_parser *p,
        cmd = radeon_get_ib_value(p, p->idx) >> 1;
 
        if (cmd < 0x4) {
+               if (end <= start) {
+                       DRM_ERROR("invalid reloc offset %X!\n", offset);
+                       return -EINVAL;
+               }
                if ((end - start) < buf_sizes[cmd]) {
                        DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
                                  (unsigned)(end - start), buf_sizes[cmd]);