hamradio/yam: fix info leak in ioctl
authorSalva Peiró <speiro@ai2.upv.es>
Tue, 17 Dec 2013 09:06:30 +0000 (10:06 +0100)
committerWilly Tarreau <w@1wt.eu>
Mon, 19 May 2014 05:54:08 +0000 (07:54 +0200)
[ Upstream commit 8e3fbf870481eb53b2d3a322d1fc395ad8b367ed ]

The yam_ioctl() code fails to initialise the cmd field
of the struct yamdrv_ioctl_cfg. Add an explicit memset(0)
before filling the structure to avoid the 4-byte info leak.

Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/net/hamradio/yam.c

index 694132e04af697a4b78518708d0e6471046223bc..1a1002d069b9d48809532e202a942ed8e96d734e 100644 (file)
@@ -1060,6 +1060,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
                break;
 
        case SIOCYAMGCFG:
+               memset(&yi, 0, sizeof(yi));
                yi.cfg.mask = 0xffffffff;
                yi.cfg.iobase = yp->iobase;
                yi.cfg.irq = yp->irq;