mmap: #if 0 unneeded code instead of commenting it out
authorYiannis Pericleous <yiannos@louie.fsl.cs.sunysb.edu>
Tue, 1 May 2007 23:11:53 +0000 (19:11 -0400)
committerErez Zadok <ezk@cs.sunysb.edu>
Mon, 12 Jan 2009 23:20:27 +0000 (18:20 -0500)
fs/unionfs/file.c

index 28565a19ed96b968858186373ebd2b71282a6a8e..4f6859c4f29c7396fa266f1248e9a60c6c457eac 100644 (file)
@@ -33,12 +33,12 @@ static ssize_t unionfs_read(struct file *file, char __user *buf,
 
        err = do_sync_read(file, buf, count, ppos);
 
-/*
+#if 0
        FIXME: do_sync_read updates a time
        if (err >= 0)
                touch_atime(unionfs_lower_mnt(file->f_path.dentry),
                                unionfs_lower_dentry(file->f_path.dentry));
-*/
+#endif
 
 out:
        unionfs_read_unlock(file->f_dentry->d_sb);
@@ -49,7 +49,6 @@ out:
 static ssize_t unionfs_aio_read(struct kiocb *iocb, const struct iovec *iov,
                                unsigned long nr_segs, loff_t pos)
 {
-       struct file *file = iocb->ki_filp;
        int err;
 #error fixme fxn check_file? read_unlock?
        err = generic_file_aio_read(iocb, iov, nr_segs, pos);
@@ -57,11 +56,12 @@ static ssize_t unionfs_aio_read(struct kiocb *iocb, const struct iovec *iov,
        if (err == -EIOCBQUEUED)
                err = wait_on_sync_kiocb(iocb);
 
-/*     XXX: is this needed?
+#if 0
+       XXX: is this needed?
        if (err >= 0)
-               touch_atime(unionfs_lower_mnt(file->f_path.dentry),
-                               unionfs_lower_dentry(file->f_path.dentry));
-*/
+               touch_atime(unionfs_lower_mnt(iocb->ki_filp->f_path.dentry),
+                               unionfs_lower_dentry(iocb->ki_filp->f_path.dentry));
+#endif
 
 #if 0
 out: