mmap: read upper file instead of lower file
authorYiannis Pericleous <yiannos@louie.fsl.cs.sunysb.edu>
Tue, 1 May 2007 19:18:39 +0000 (15:18 -0400)
committerErez_Zadok <ezk@cs.sunysb.edu>
Mon, 23 Jul 2007 00:50:39 +0000 (20:50 -0400)
dont touch atimes on reads

fs/unionfs/file.c

index caf4f9dc3f2ac96aa364db4fc4bb7c13ce8eb280..28565a19ed96b968858186373ebd2b71282a6a8e 100644 (file)
@@ -31,12 +31,14 @@ static ssize_t unionfs_read(struct file *file, char __user *buf,
        if ((err = unionfs_file_revalidate(file, 0)))
                goto out;
 
-       err = do_sync_read(unionfs_lower_file(file), buf, count, ppos);
+       err = do_sync_read(file, buf, count, ppos);
 
-       /* FIXME: why? */
+/*
+       FIXME: do_sync_read updates a time
        if (err >= 0)
                touch_atime(unionfs_lower_mnt(file->f_path.dentry),
                                unionfs_lower_dentry(file->f_path.dentry));
+*/
 
 out:
        unionfs_read_unlock(file->f_dentry->d_sb);
@@ -55,10 +57,11 @@ static ssize_t unionfs_aio_read(struct kiocb *iocb, const struct iovec *iov,
        if (err == -EIOCBQUEUED)
                err = wait_on_sync_kiocb(iocb);
 
-       /* FIXME: why? */
+/*     XXX: is this needed?
        if (err >= 0)
                touch_atime(unionfs_lower_mnt(file->f_path.dentry),
                                unionfs_lower_dentry(file->f_path.dentry));
+*/
 
 #if 0
 out: