* amd/amd.c (main) : fixed memory leak detected by valgrind

* amd/info_ldap.c (amu_ldap_init) : fixed memory leak detected by
valgrind

diff --git a/ChangeLog b/ChangeLog
index 48ca4243c9cfd7eb3e77437c5481f62208e6b36f..a54148f3cc99a99596b92688b9e88cc8f24c55ac 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2005-05-11  Daniel P. Ottavio  <dottavio@ic.sunysb.edu>
+
+       * amd/amd.c (main) : fixed memory leak detected by valgrind
+
+       * amd/info_ldap.c (amu_ldap_init) : fixed memory leak detected by
+       valgrind
+
 2005-05-11  Erez Zadok  <ezk@cs.sunysb.edu>
 
        * m4/macros/{check_checkmount_style.m4, check_mnttab_style.m4,

diff --git a/amd/amd.c b/amd/amd.c
index f091c3783e448a75ed05f9420c45fb3c70ae1a73..de41fc36130741a8ddbe078c25c6bb92c908330e 100644 (file)
--- a/amd/amd.c
+++ b/amd/amd.c
@@ -37,7 +37,7 @@
  * SUCH DAMAGE.
  *
  *
- * $Id: amd.c,v 1.35 2005/03/08 06:05:33 ezk Exp $
+ * $Id: amd.c,v 1.36 2005/05/12 23:01:25 ottavio Exp $
  *
  */
 
@@ -382,7 +382,7 @@ do_memory_locking(void)
 int
 main(int argc, char *argv[])
 {
-  char *domdot, *verstr;
+  char *domdot, *verstr, *vertmp;
   int ppid = 0;
   int error;
   char *progname = NULL;               /* "amd" */
@@ -546,12 +546,14 @@ main(int argc, char *argv[])
   /*
    * Log version information.
    */
-  verstr = strtok(get_version_string(), "\n");
+  vertmp = get_version_string();
+  verstr = strtok(vertmp, "\n");
   plog(XLOG_INFO, "AM-UTILS VERSION INFORMATION:");
   while (verstr) {
     plog(XLOG_INFO, "%s", verstr);
     verstr = strtok(NULL, "\n");
   }
+  XFREE(vertmp);
 
   /*
    * Get our own IP address so that we can mount the automounter.  We pass

diff --git a/amd/info_ldap.c b/amd/info_ldap.c
index 6b78cb4ece9e55a3abb4124deabfd4765e919bc2..ca4cab9a9e6de6315940f840090d15bf18bb9b58 100644 (file)
--- a/amd/info_ldap.c
+++ b/amd/info_ldap.c
@@ -37,7 +37,7 @@
  * SUCH DAMAGE.
  *
  *
- * $Id: info_ldap.c,v 1.24 2005/01/03 20:56:45 ezk Exp $
+ * $Id: info_ldap.c,v 1.25 2005/05/12 23:01:25 ottavio Exp $
  *
  */
 
@@ -245,6 +245,8 @@ amu_ldap_init(mnt_map *m, char *map, time_t *ts)
   if (aldh->hostent == NULL) {
     plog(XLOG_USER, "Unable to parse hostport %s for ldap map %s",
         gopt.ldap_hostports ? gopt.ldap_hostports : "(null)", map);
+    XFREE(creds);
+    XFREE(aldh);
     return (ENOENT);
   }
   creds->who = "";