xen-blkback: replace work_pending with work_busy in purge_persistent_gnt()
authorBob Liu <bob.liu@oracle.com>
Wed, 22 Jul 2015 06:40:10 +0000 (14:40 +0800)
committerSasha Levin <sasha.levin@oracle.com>
Tue, 15 Sep 2015 17:56:47 +0000 (13:56 -0400)
[ Upstream commit 53bc7dc004fecf39e0ba70f2f8d120a1444315d3 ]

The BUG_ON() in purge_persistent_gnt() will be triggered when previous purge
work haven't finished.

There is a work_pending() before this BUG_ON, but it doesn't account if the work
is still currently running.

CC: stable@vger.kernel.org
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Bob Liu <bob.liu@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/block/xen-blkback/blkback.c

index 63fc7f06a0146821296e2d4c625f680d6c9ac008..0c858a60dc403677c0a23a67a1da150ca3cfcba8 100644 (file)
@@ -350,7 +350,7 @@ static void purge_persistent_gnt(struct xen_blkif *blkif)
                return;
        }
 
-       if (work_pending(&blkif->persistent_purge_work)) {
+       if (work_busy(&blkif->persistent_purge_work)) {
                pr_alert_ratelimited(DRV_PFX "Scheduled work from previous purge is still pending, cannot purge list\n");
                return;
        }