selftests: bpf: test_sockmap: handle file creation failures gracefully

[ Upstream commit 4b67c515036313f3c3ecba3cb2babb9cbddb3f85 ]

test_sockmap creates a temporary file to use for sendpage.
this may fail for various reasons. Handle the error rather
than segfault.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
index 0c7d9e556b47d0a8129586a634a423e4ad1af067..a7fc91bb9119ce4001656a6507969d851f135b82 100644 (file)
--- a/tools/testing/selftests/bpf/test_sockmap.c
+++ b/tools/testing/selftests/bpf/test_sockmap.c
@@ -248,6 +248,10 @@ static int msg_loop_sendpage(int fd, int iov_length, int cnt,
        int i, fp;
 
        file = fopen(".sendpage_tst.tmp", "w+");
+       if (!file) {
+               perror("create file for sendpage");
+               return 1;
+       }
        for (i = 0; i < iov_length * cnt; i++, k++)
                fwrite(&k, sizeof(char), 1, file);
        fflush(file);
@@ -255,6 +259,11 @@ static int msg_loop_sendpage(int fd, int iov_length, int cnt,
        fclose(file);
 
        fp = open(".sendpage_tst.tmp", O_RDONLY);
+       if (fp < 0) {
+               perror("reopen file for sendpage");
+               return 1;
+       }
+
        clock_gettime(CLOCK_MONOTONIC, &s->start);
        for (i = 0; i < cnt; i++) {
                int sent = sendfile(fd, fp, NULL, iov_length);