projects
/
wrapfs-5.3.y.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dd035ca
)
drm/vc4: fix error code in vc4_create_object()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 18 Nov 2021 11:14:16 +0000
(14:14 +0300)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 8 Dec 2021 07:46:49 +0000
(08:46 +0100)
[ Upstream commit
96c5f82ef0a145d3e56e5b26f2bf6dcd2ffeae1c
]
The ->gem_create_object() functions are supposed to return NULL if there
is an error. None of the callers expect error pointers so returing one
will lead to an Oops. See drm_gem_vram_create(), for example.
Fixes: c826a6e10644 ("drm/vc4: Add a BO cache.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link:
https://patchwork.freedesktop.org/patch/msgid/20211118111416.GC1147@kili
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/vc4/vc4_bo.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/vc4/vc4_bo.c
b/drivers/gpu/drm/vc4/vc4_bo.c
index eff0a8ece8bcfdee6fd189251ead02727c8f0e11..85abba74ed9816604322228c2e4287c432466115 100644
(file)
--- a/
drivers/gpu/drm/vc4/vc4_bo.c
+++ b/
drivers/gpu/drm/vc4/vc4_bo.c
@@
-292,7
+292,7
@@
struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size)
bo = kzalloc(sizeof(*bo), GFP_KERNEL);
if (!bo)
- return
ERR_PTR(-ENOMEM)
;
+ return
NULL
;
mutex_lock(&vc4->bo_lock);
bo->label = VC4_BO_TYPE_KERNEL;