mfd: kempld-core: Fix callback return value check
authorAmeya Palande <2ameya@gmail.com>
Thu, 26 Feb 2015 20:05:51 +0000 (12:05 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Apr 2015 12:03:04 +0000 (14:03 +0200)
commit c8648508ebfc597058d2cd00b6c539110264a167 upstream.

On success, callback function returns 0. So invert the if condition
check so that we can break out of loop.

Signed-off-by: Ameya Palande <2ameya@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mfd/kempld-core.c

index 38917a82233521768d3a1623046f68025de24295..2df3cbc968d173626b9db64695a0b64e71eadd5f 100644 (file)
@@ -629,7 +629,7 @@ static int __init kempld_init(void)
        if (force_device_id[0]) {
                for (id = kempld_dmi_table; id->matches[0].slot != DMI_NONE; id++)
                        if (strstr(id->ident, force_device_id))
-                               if (id->callback && id->callback(id))
+                               if (id->callback && !id->callback(id))
                                        break;
                if (id->matches[0].slot == DMI_NONE)
                        return -ENODEV;