USB: Also match device drivers using the ->match vfunc
authorBastien Nocera <hadess@hadess.net>
Tue, 18 Aug 2020 11:04:43 +0000 (13:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:29:49 +0000 (11:29 +0200)
commit adb6e6ac20eedcf1dce19dc75b224e63c0828ea1 upstream.

We only ever used the ID table matching before, but we should also support
open-coded match functions.

Fixes: 88b7381a939de ("USB: Select better matching USB drivers when available")
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Cc: stable <stable@vger.kernel.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20200818110445.509668-1-hadess@hadess.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/generic.c

index 4626227a6dd223c037907dc999412486d8b581bd..cd08a47144bd3c222488dc1085bb40d096de35d6 100644 (file)
@@ -207,8 +207,9 @@ static int __check_usb_generic(struct device_driver *drv, void *data)
                return 0;
        if (!udrv->id_table)
                return 0;
-
-       return usb_device_match_id(udev, udrv->id_table) != NULL;
+       if (usb_device_match_id(udev, udrv->id_table) != NULL)
+               return 1;
+       return (udrv->match && udrv->match(udev));
 }
 
 static bool usb_generic_driver_match(struct usb_device *udev)