mvsas: fix misleading indentation
authorLuis de Bethencourt <luisbg@osg.samsung.com>
Mon, 30 Nov 2015 14:32:17 +0000 (14:32 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Apr 2017 05:55:50 +0000 (07:55 +0200)
commit 7789cd39274c51bf475411fe22a8ee7255082809 upstream.

Fix a smatch warning:
drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended?

The code is correct, the indention is misleading. When the device is not
ready we want to return SAS_PHY_DOWN. But current indentation makes it
look like we only do so in the else branch of if (mvi_dev).

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/mvsas/mv_sas.c

index 89215d44d83fa9d4b3e1083b6a3e2cfb9b60428c..f054d8dee0134ddb042e12c74db42903d04dfc6c 100644 (file)
@@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
                        mv_dprintk("device %016llx not ready.\n",
                                SAS_ADDR(dev->sas_addr));
 
-                       rc = SAS_PHY_DOWN;
-                       return rc;
+               rc = SAS_PHY_DOWN;
+               return rc;
        }
        tei.port = dev->port->lldd_port;
        if (tei.port && !tei.port->port_attached && !tmf) {