aacraid: missing capable() check in compat ioctl
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 29 Oct 2013 19:11:06 +0000 (19:11 +0000)
committerWilly Tarreau <w@1wt.eu>
Mon, 19 May 2014 05:54:35 +0000 (07:54 +0200)
commit f856567b930dfcdbc3323261bf77240ccdde01f5 upstream

In commit d496f94d22d1 ('[SCSI] aacraid: fix security weakness') we
added a check on CAP_SYS_RAWIO to the ioctl.  The compat ioctls need the
check as well.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/scsi/aacraid/linit.c

index 9b97c3e016fe8233b0545ea8adab6bb45ff3985d..387872c98dc5817e9feffa946eb40aa7755cd783 100644 (file)
@@ -754,6 +754,8 @@ static long aac_compat_do_ioctl(struct aac_dev *dev, unsigned cmd, unsigned long
 static int aac_compat_ioctl(struct scsi_device *sdev, int cmd, void __user *arg)
 {
        struct aac_dev *dev = (struct aac_dev *)sdev->host->hostdata;
+       if (!capable(CAP_SYS_RAWIO))
+               return -EPERM;
        return aac_compat_do_ioctl(dev, cmd, (unsigned long)arg);
 }