atm: idt77252: fix dev refcnt leak
authorYing Xue <ying.xue@windriver.com>
Tue, 19 Nov 2013 10:09:27 +0000 (18:09 +0800)
committerWilly Tarreau <w@1wt.eu>
Mon, 19 May 2014 05:54:03 +0000 (07:54 +0200)
[ Upstream commit b5de4a22f157ca345cdb3575207bf46402414bc1 ]

init_card() calls dev_get_by_name() to get a network deceive. But it
doesn't decrease network device reference count after the device is
used.

Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/atm/idt77252.c

index e33ae0025b1214c45e0380e495d7e135dc4a59a5..adbaed59654aed7eb76e25ebd5023c2cc4b93148 100644 (file)
@@ -3557,6 +3557,7 @@ init_card(struct atm_dev *dev)
        if (tmp) {
                memcpy(card->atmdev->esi, tmp->dev_addr, 6);
 
+               dev_put(tmp);
                printk("%s: ESI %02x:%02x:%02x:%02x:%02x:%02x\n",
                       card->name, card->atmdev->esi[0], card->atmdev->esi[1],
                       card->atmdev->esi[2], card->atmdev->esi[3],