xfs: fix incorrect test in xfs_alloc_ag_vextent_lastblock

[ Upstream commit 77ca1eed5a7d2bf0905562eb1a15aac76bc19fe4 ]

When I lifted the code in xfs_alloc_ag_vextent_lastblock out of a loop,
I forgot to convert all the accesses to len to be pointer dereferences.

Coverity-id: 1457918
Fixes: 5113f8ec3753ed ("xfs: clean up weird while loop in xfs_alloc_ag_vextent_near")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index d8053bc96c4d2393093ab74d354ff1f9c44aac0d..5a130409f173eccc43254b27ab5d5af083476993 100644 (file)
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -1515,7 +1515,7 @@ xfs_alloc_ag_vextent_lastblock(
         * maxlen, go to the start of this block, and skip all those smaller
         * than minlen.
         */
-       if (len || args->alignment > 1) {
+       if (*len || args->alignment > 1) {
                acur->cnt->bc_ptrs[0] = 1;
                do {
                        error = xfs_alloc_get_rec(acur->cnt, bno, len, &i);