afs: Fix the afs.cell and afs.volume xattr handlers

[ Upstream commit c73aa4102f5b9f261a907c3b3df94cd2c478504d ]

Fix the ->get handlers for the afs.cell and afs.volume xattrs to pass the
source data size to memcpy() rather than target buffer size.

Overcopying the source data occasionally causes the kernel to oops.

Fixes: d3e3b7eac886 ("afs: Add metadata xattrs")
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/afs/xattr.c b/fs/afs/xattr.c
index 2830e4f48d85445b18f0cd6a39c3a22a35daac79..7c6b62a94e7e7e5986ef925bde8674fe15ace1e2 100644 (file)
--- a/fs/afs/xattr.c
+++ b/fs/afs/xattr.c
@@ -50,7 +50,7 @@ static int afs_xattr_get_cell(const struct xattr_handler *handler,
                return namelen;
        if (namelen > size)
                return -ERANGE;
-       memcpy(buffer, cell->name, size);
+       memcpy(buffer, cell->name, namelen);
        return namelen;
 }
 
@@ -104,7 +104,7 @@ static int afs_xattr_get_volume(const struct xattr_handler *handler,
                return namelen;
        if (namelen > size)
                return -ERANGE;
-       memcpy(buffer, volname, size);
+       memcpy(buffer, volname, namelen);
        return namelen;
 }