remoteproc: k3-r5: Fix an error message
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 6 May 2021 20:46:01 +0000 (22:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:02:17 +0000 (16:02 +0200)
[ Upstream commit 34c4da6d5dfba48f49f891ebd75bb55999f0c538 ]

'ret' is known to be 0 here.
Reorder the code so that the expected error code is printed.

Acked-by: Suman Anna <s-anna@ti.com>
Fixes: 6dedbd1d5443 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/d6e29d903b48957bf59c67229d54b0fc215e31ae.1620333870.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/remoteproc/ti_k3_r5_remoteproc.c

index 62b5a4c294562a6b365bda60e2467040ff677aa1..914db1d1f6381cda95b8d93ae46fba537c6e24f7 100644 (file)
@@ -1272,9 +1272,9 @@ static int k3_r5_core_of_init(struct platform_device *pdev)
 
        core->tsp = k3_r5_core_of_get_tsp(dev, core->ti_sci);
        if (IS_ERR(core->tsp)) {
+               ret = PTR_ERR(core->tsp);
                dev_err(dev, "failed to construct ti-sci proc control, ret = %d\n",
                        ret);
-               ret = PTR_ERR(core->tsp);
                goto err;
        }