Bluetooth: Put HCI device if inquiry procedure interrupts
authorPan Bian <bianpan2016@163.com>
Thu, 21 Jan 2021 08:10:45 +0000 (00:10 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Mar 2021 16:44:33 +0000 (17:44 +0100)
[ Upstream commit 28a758c861ff290e39d4f1ee0aa5df0f0b9a45ee ]

Jump to the label done to decrement the reference count of HCI device
hdev on path that the Inquiry procedure is interrupted.

Fixes: 3e13fa1e1fab ("Bluetooth: Fix hci_inquiry ioctl usage")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/bluetooth/hci_core.c

index a70b078ceb3caf2d276e769e009d369c1c9c11ba..02f44a408edbde7704010b890e8ab4f18c9b2926 100644 (file)
@@ -1243,8 +1243,10 @@ int hci_inquiry(void __user *arg)
                 * cleared). If it is interrupted by a signal, return -EINTR.
                 */
                if (wait_on_bit(&hdev->flags, HCI_INQUIRY,
-                               TASK_INTERRUPTIBLE))
-                       return -EINTR;
+                               TASK_INTERRUPTIBLE)) {
+                       err = -EINTR;
+                       goto done;
+               }
        }
 
        /* for unlimited number of responses we will use buffer with