KVM: PPC: Book3S: Suppress failed alloc warning in H_COPY_TOFROM_GUEST
authorAlexey Kardashevskiy <aik@ozlabs.ru>
Wed, 1 Sep 2021 08:45:50 +0000 (18:45 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 08:19:48 +0000 (09:19 +0100)
[ Upstream commit 792020907b11c6f9246c21977cab3bad985ae4b6 ]

H_COPY_TOFROM_GUEST is an hcall for an upper level VM to access its nested
VMs memory. The userspace can trigger WARN_ON_ONCE(!(gfp & __GFP_NOWARN))
in __alloc_pages() by constructing a tiny VM which only does
H_COPY_TOFROM_GUEST with a too big GPR9 (number of bytes to copy).

This silences the warning by adding __GFP_NOWARN.

Spotted by syzkaller.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Fabiano Rosas <farosas@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210901084550.1658699-1-aik@ozlabs.ru
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/kvm/book3s_hv_nested.c

index 9906d203d9d399ae0ddee8881647419d7de59046..613d24b707abea760b1c60495a08d5e10738d0b4 100644 (file)
@@ -510,7 +510,7 @@ long kvmhv_copy_tofrom_guest_nested(struct kvm_vcpu *vcpu)
        if (eaddr & (0xFFFUL << 52))
                return H_PARAMETER;
 
-       buf = kzalloc(n, GFP_KERNEL);
+       buf = kzalloc(n, GFP_KERNEL | __GFP_NOWARN);
        if (!buf)
                return H_NO_MEM;