cpufreq: update 'cpufreq_suspended' after stopping governors
authorViresh Kumar <viresh.kumar@linaro.org>
Tue, 30 Sep 2014 04:03:17 +0000 (09:33 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Oct 2014 20:41:11 +0000 (13:41 -0700)
commit b1b12babe3b72cfb08b875245e5a5d7c2747c772 upstream.

Commit 8e30444e1530 ("cpufreq: fix cpufreq suspend/resume for intel_pstate")
introduced a bug where the governors wouldn't be stopped anymore for
->target{_index}() drivers during suspend. This happens because
'cpufreq_suspended' is updated before stopping the governors during suspend
and due to this __cpufreq_governor() would return early due to this check:

/* Don't start any governor operations if we are entering suspend */
if (cpufreq_suspended)
return 0;

Fixes: 8e30444e1530 ("cpufreq: fix cpufreq suspend/resume for intel_pstate")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/cpufreq/cpufreq.c

index 1edeaad718df73594156de2df50c4bd1f741a67c..21ab8bcd4d20b7a5ab3c6fe8e468ba2a4e087105 100644 (file)
@@ -1666,10 +1666,8 @@ void cpufreq_suspend(void)
        if (!cpufreq_driver)
                return;
 
-       cpufreq_suspended = true;
-
        if (!has_target())
-               return;
+               goto suspend;
 
        pr_debug("%s: Suspending Governors\n", __func__);
 
@@ -1682,6 +1680,9 @@ void cpufreq_suspend(void)
                        pr_err("%s: Failed to suspend driver: %p\n", __func__,
                                policy);
        }
+
+suspend:
+       cpufreq_suspended = true;
 }
 
 /**