Fix a masking bug in the 6pack driver.
authorJean Delvare <khali@linux-fr.org>
Wed, 29 Nov 2006 10:00:25 +0000 (11:00 +0100)
committerAdrian Bunk <bunk@stusta.de>
Wed, 29 Nov 2006 10:00:25 +0000 (11:00 +0100)
Looks like a broken masking to me, binary not is used where bitwise
not was intended.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
drivers/net/hamradio/6pack.c

index 102c1f0b90dac7a941902322dbc33cfd295c1799..d1f689586713558d3c866576f6ac5d2966b5bbf6 100644 (file)
@@ -915,7 +915,7 @@ static void decode_prio_command(struct sixpack *sp, unsigned char cmd)
                                        printk(KERN_DEBUG "6pack: protocol violation\n");
                                else
                                        sp->status = 0;
-                               cmd &= !SIXP_RX_DCD_MASK;
+                               cmd &= ~SIXP_RX_DCD_MASK;
                }
                sp->status = cmd & SIXP_PRIO_DATA_MASK;
        } else { /* output watchdog char if idle */