reset: core: fix reset_control_put
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 1 Feb 2017 07:05:22 +0000 (08:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 8 Dec 2018 12:05:08 +0000 (13:05 +0100)
commit 4891486fb2c80eaf3bb0f9eb065d15ecd357702f upstream.

Commit "reset: make optional functions really optional" missed to
adjust one check in reset_control_put, causing a NULL pointer
access for optional resets.

Fixes: bb475230b8e5 "reset: make optional functions really optional"
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/reset/core.c

index 75821417b799f995641fb5e1d77056598d988044..f62f57ebc45a046778e33d75365c959e04e0e830 100644 (file)
@@ -358,7 +358,7 @@ EXPORT_SYMBOL_GPL(__of_reset_control_get);
 
 void reset_control_put(struct reset_control *rstc)
 {
-       if (IS_ERR(rstc))
+       if (IS_ERR_OR_NULL(rstc))
                return;
 
        mutex_lock(&reset_list_mutex);