ubifs: rename_whiteout: correct old_dir size computing
authorBaokun Li <libaokun1@huawei.com>
Tue, 15 Feb 2022 04:07:36 +0000 (12:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:08:24 +0000 (09:08 +0200)
commit 705757274599e2e064dd3054aabc74e8af31a095 upstream.

When renaming the whiteout file, the old whiteout file is not deleted.
Therefore, we add the old dentry size to the old dir like XFS.
Otherwise, an error may be reported due to `fscki->calc_sz != fscki->size`
in check_indes.

Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT")
Reported-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ubifs/dir.c

index c49b10c5ae1db94eea21ca50b2736422fbf014b4..12356dcc3ecb9c486bba064259e039c22f9cb71d 100644 (file)
@@ -1452,6 +1452,9 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry,
                        if (unlink)
                                drop_nlink(old_dir);
                }
+
+               /* Add the old_dentry size to the old_dir size. */
+               old_sz -= CALC_DENT_SIZE(fname_len(&old_nm));
        }
 
        old_dir->i_size -= old_sz;