s390/qdio: handle PENDING state for QEBSM devices
authorJulian Wiedmann <jwi@linux.ibm.com>
Mon, 3 Jun 2019 05:47:04 +0000 (07:47 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 31 Oct 2019 22:14:52 +0000 (22:14 +0000)
commit 04310324c6f482921c071444833e70fe861b73d9 upstream.

When a CQ-enabled device uses QEBSM for SBAL state inspection,
get_buf_states() can return the PENDING state for an Output Queue.
get_outbound_buffer_frontier() isn't prepared for this, and any PENDING
buffer will permanently stall all further completion processing on this
Queue.

This isn't a concern for non-QEBSM devices, as get_buf_states() for such
devices will manually turn PENDING buffers into EMPTY ones.

Fixes: 104ea556ee7f ("qdio: support asynchronous delivery of storage blocks")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/s390/cio/qdio_main.c

index 90f93c2be8cde4b52f1f6619eb12554ef324752e..dae0196a61b65fc63ee49f300ebfb72f9aa66406 100644 (file)
@@ -752,6 +752,7 @@ static int get_outbound_buffer_frontier(struct qdio_q *q)
 
        switch (state) {
        case SLSB_P_OUTPUT_EMPTY:
+       case SLSB_P_OUTPUT_PENDING:
                /* the adapter got it */
                DBF_DEV_EVENT(DBF_INFO, q->irq_ptr,
                        "out empty:%1d %02x", q->nr, count);