projects
/
wrapfs-3.14.y.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4d837a4
)
MIPS: microMIPS: Fix incorrect mask in insn_table_MM
author
Gustavo A. R. Silva
<garsilva@embeddedor.com>
Tue, 31 Oct 2017 05:35:03 +0000
(
00:35
-0500)
committer
Ben Hutchings
<ben@decadent.org.uk>
Mon, 1 Jan 2018 20:52:02 +0000
(20:52 +0000)
commit
77238e76b9156d28d86c1e31c00ed2960df0e4de
upstream.
It seems that this is a typo error and the proper bit masking is
"RT | RS" instead of "RS | RS".
This issue was detected with the help of Coccinelle.
Fixes: d6b3314b49e1 ("MIPS: uasm: Add lh uam instruction")
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: James Hogan <jhogan@kernel.org>
Patchwork: https://patchwork.linux-mips.org/patch/17551/
Signed-off-by: James Hogan <jhogan@kernel.org>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/mips/mm/uasm-micromips.c
patch
|
blob
|
history
diff --git
a/arch/mips/mm/uasm-micromips.c
b/arch/mips/mm/uasm-micromips.c
index 8399ddf03a0235c5ce9d5ee28ed5007c9986a8ab..cab124e0572d03e209f09f27a8096d84c942341e 100644
(file)
--- a/
arch/mips/mm/uasm-micromips.c
+++ b/
arch/mips/mm/uasm-micromips.c
@@
-83,7
+83,7
@@
static struct insn insn_table_MM[] = {
{ insn_jr, M(mm_pool32a_op, 0, 0, 0, mm_jalr_op, mm_pool32axf_op), RS },
{ insn_lb, M(mm_lb32_op, 0, 0, 0, 0, 0), RT | RS | SIMM },
{ insn_ld, 0, 0 },
- { insn_lh, M(mm_lh32_op, 0, 0, 0, 0, 0), R
S
| RS | SIMM },
+ { insn_lh, M(mm_lh32_op, 0, 0, 0, 0, 0), R
T
| RS | SIMM },
{ insn_ll, M(mm_pool32c_op, 0, 0, (mm_ll_func << 1), 0, 0), RS | RT | SIMM },
{ insn_lld, 0, 0 },
{ insn_lui, M(mm_pool32i_op, mm_lui_op, 0, 0, 0, 0), RS | SIMM },