Revert "net: sched: bump refcount for new action in ACT replace mode"
authorVlad Buslov <vladbu@nvidia.com>
Wed, 7 Apr 2021 15:36:02 +0000 (18:36 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Apr 2021 06:47:26 +0000 (08:47 +0200)
commit 4ba86128ba077fbb7d86516ae24ed642e6c3adef upstream.

This reverts commit 6855e8213e06efcaf7c02a15e12b1ae64b9a7149.

Following commit in series fixes the issue without introducing regression
in error rollback of tcf_action_destroy().

Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sched/act_api.c

index 2ba46893884f0f7c2869686f26509d0c7d7dd127..f6d5755d669eba66a40b44088b362c8ae6f8d934 100644 (file)
@@ -1049,9 +1049,6 @@ struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp,
        if (!name)
                a->hw_stats = hw_stats;
 
-       if (!bind && ovr && err == ACT_P_CREATED)
-               refcount_set(&a->tcfa_refcnt, 2);
-
        return a;
 
 err_out: