PCI/MSI: Use msi_mask_irq() in pci_msi_shutdown()
authorThomas Gleixner <tglx@linutronix.de>
Thu, 29 Jul 2021 21:51:46 +0000 (23:51 +0200)
committerSasha Levin <sashal@kernel.org>
Thu, 26 Aug 2021 12:37:04 +0000 (08:37 -0400)
commit d28d4ad2a1aef27458b3383725bb179beb8d015c upstream.

No point in using the raw write function from shutdown. Preparatory change
to introduce proper serialization for the msi_desc::masked cache.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20210729222542.674391354@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/msi.c

index 93dd4c69cc4634d824acd612a251bf4175400b3c..034f60b75a6e0982a9152807e4ec26d0730a9975 100644 (file)
@@ -896,7 +896,7 @@ static void pci_msi_shutdown(struct pci_dev *dev)
 
        /* Return the device with MSI unmasked as initial states */
        mask = msi_mask(desc->msi_attrib.multi_cap);
-       __pci_msi_desc_mask_irq(desc, mask, 0);
+       msi_mask_irq(desc, mask, 0);
 
        /* Restore dev->irq to its default pin-assertion irq */
        dev->irq = desc->msi_attrib.default_irq;